Skip to content

HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…#2019

Merged
infraio merged 1 commit intoapache:HBASE-24666from
infraio:HBASE-24681
Jul 13, 2020
Merged

HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…#2019
infraio merged 1 commit intoapache:HBASE-24666from
infraio:HBASE-24681

Conversation

@infraio
Copy link
Contributor

@infraio infraio commented Jul 6, 2020

…plicationSourceManager

@Apache-HBase
Copy link

Apache-HBase commented Jul 6, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 3m 47s HBASE-24666 passed
+1 💚 checkstyle 1m 8s HBASE-24666 passed
+1 💚 spotbugs 1m 59s HBASE-24666 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 21s the patch passed
-0 ⚠️ checkstyle 1m 2s hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 10s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 2m 6s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
32m 24s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2019
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 91cf0d917179 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / fe2ae80
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 6, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 4m 19s HBASE-24666 passed
+1 💚 compile 1m 4s HBASE-24666 passed
+1 💚 shadedjars 5m 51s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 44s hbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 1m 3s the patch passed
+1 💚 javac 1m 3s the patch passed
+1 💚 shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 136m 11s hbase-server in the patch failed.
162m 18s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2019
Optional Tests javac javadoc unit shadedjars compile
uname Linux 24549fb1185f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / fe2ae80
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/testReport/
Max. process+thread count 4761 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 6, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 4m 2s HBASE-24666 passed
+1 💚 compile 0m 57s HBASE-24666 passed
+1 💚 shadedjars 5m 59s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s HBASE-24666 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 42s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 shadedjars 6m 1s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 36s hbase-server generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28)
_ Other Tests _
-1 ❌ unit 205m 21s hbase-server in the patch failed.
230m 25s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2019
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5464af8faf74 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / fe2ae80
Default Java 1.8.0_232
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/testReport/
Max. process+thread count 3916 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 8, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 3m 34s HBASE-24666 passed
+1 💚 checkstyle 1m 7s HBASE-24666 passed
+1 💚 spotbugs 2m 2s HBASE-24666 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 21s the patch passed
+1 💚 checkstyle 1m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 9s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 2m 40s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
35m 5s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2019
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 07fea145f23d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / c294971
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 8, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 3m 48s HBASE-24666 passed
+1 💚 compile 0m 55s HBASE-24666 passed
+1 💚 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s HBASE-24666 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 shadedjars 5m 33s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 36s hbase-server generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28)
_ Other Tests _
+1 💚 unit 141m 35s hbase-server in the patch passed.
165m 57s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2019
Optional Tests javac javadoc unit shadedjars compile
uname Linux d9d40903c967 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / c294971
Default Java 1.8.0_232
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/testReport/
Max. process+thread count 4710 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 8, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 47s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 5m 15s HBASE-24666 passed
+1 💚 compile 1m 15s HBASE-24666 passed
+1 💚 shadedjars 6m 47s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 46s hbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 55s the patch passed
+1 💚 compile 1m 28s the patch passed
+1 💚 javac 1m 28s the patch passed
+1 💚 shadedjars 6m 58s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 45s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 149m 42s hbase-server in the patch failed.
180m 36s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2019
Optional Tests javac javadoc unit shadedjars compile
uname Linux 39aeeeb16c39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / c294971
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/testReport/
Max. process+thread count 4455 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 10, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 3m 36s HBASE-24666 passed
+1 💚 checkstyle 1m 3s HBASE-24666 passed
+1 💚 spotbugs 2m 0s HBASE-24666 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 25s the patch passed
+1 💚 checkstyle 1m 6s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 31s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 2m 44s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
35m 29s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2019
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 6ccdd6a84494 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / c294971
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 10, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 3m 34s HBASE-24666 passed
+1 💚 compile 0m 56s HBASE-24666 passed
+1 💚 shadedjars 5m 38s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s HBASE-24666 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 shadedjars 5m 34s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 35s the patch passed
_ Other Tests _
+1 💚 unit 142m 14s hbase-server in the patch passed.
166m 16s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2019
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0e1a963ab077 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / c294971
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/testReport/
Max. process+thread count 4384 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 10, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚 mvninstall 4m 47s HBASE-24666 passed
+1 💚 compile 1m 10s HBASE-24666 passed
+1 💚 shadedjars 6m 51s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 46s hbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 53s the patch passed
+1 💚 compile 1m 12s the patch passed
+1 💚 javac 1m 12s the patch passed
+1 💚 shadedjars 6m 46s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 45s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 224m 27s hbase-server in the patch passed.
255m 7s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2019
Optional Tests javac javadoc unit shadedjars compile
uname Linux 86581908c096 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-24666 / c294971
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/testReport/
Max. process+thread count 2976 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per HBASE-24666 design doc, ReplicationSourceManager should concern with adding wals to the ReplicationQueueStorage, so could we simply remove some of the methods related with ReplicationSources control, since ReplicationSources are now run from ReplicationServers? Apparently those methods are the only ones using this walsById cache.

@infraio
Copy link
Contributor Author

infraio commented Jul 13, 2020

Yes. But I plan to implement it piece by piece and make sure all ut passed, it will be easy for review. Will finish the complete "decouple" in the follow on issues. Meanwhile, I will add a implementation plan section in the design doc. Thanks.

@infraio infraio merged commit f176191 into apache:HBASE-24666 Jul 13, 2020
asfgit pushed a commit that referenced this pull request Jul 13, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
9e8c930 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Jul 21, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
fae9f0c 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Aug 10, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
9c61d14 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Aug 21, 2020
@infraio @ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
76645aa 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 7, 2020
@infraio @ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
940b769 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Sep 8, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
b659616 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Sep 8, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
c8f24d7 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 8, 2020
@infraio @ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
189a72e 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 10, 2020
@infraio @ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
a6e8ec8 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 14, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
d90c20e 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 15, 2020
@infraio @ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
4ec226e 
…plicationSourceManager (apache#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 23, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
e2bdc6d 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 24, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
430a813 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit that referenced this pull request Sep 26, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
38acdaa 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 29, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
5646555 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 22, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
25764a3 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit that referenced this pull request Nov 9, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
efbb75c 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit that referenced this pull request Feb 23, 2021
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
b60ec36 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit that referenced this pull request Jul 9, 2021
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
8481d54 
…plicationSourceManager (#2019)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio @Apache-HBase @wchevreuil